Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read tenant and authority from VS Code user settings #18846

Merged
merged 11 commits into from
Jun 4, 2021
Merged

Read tenant and authority from VS Code user settings #18846

merged 11 commits into from
Jun 4, 2021

Conversation

chlowell
Copy link
Member

Closes #14808

@chlowell chlowell marked this pull request as ready for review June 2, 2021 17:02
@chlowell chlowell requested review from mccoyp and schaabs as code owners June 2, 2021 17:02
mccoyp
mccoyp approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- verified locally that this works on Mac (and tests bring up requests for Keychain access)

@chlowell chlowell merged commit 0b6bdcb into Azure:master Jun 4, 2021
@chlowell chlowell deleted the vscode branch June 4, 2021 01:00
@chlowell chlowell mentioned this pull request Jun 4, 2021
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request May 24, 2022
CodeGen from PR 18846 in Azure/azure-rest-api-specs
49e90ff 
change operationIds (Azure#18846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set authority from VS Code settings
2 participants
@chlowell @mccoyp